Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add new icons and banner. - #4100

Closed
jsha wants to merge 3 commits into
EFForg:masterfrom
jsha:new-icons3
Closed

jsha wants to merge 3 commits into
EFForg:masterfrom
jsha:new-icons3

Conversation

@jsha

@jsha jsha commented Feb 6, 2016

Copy link
Copy Markdown
Member

The old icons were hard to make out at their typical size. The new icons are
clearer, and avoid the lock iconography in order to avoid creating confusion
with the lock icon in the URL bar.

Adds new icon type:
"inactive" indicates that no rules applied on a given site.
"disabled" indicates HTTPS Everywhere is disabled.

Disables the counter by default on Firefox (you can still turn
it on manually), and adds a new icon state "inactive."

cc @semenko, @cooperq, and @Hainish for review and test.

The old icons were hard to make out at their typical size. The new icons are
clearer, and avoid the lock iconography in order to avoid creating confusion
with the lock icon in the URL bar.

Adds new icon type:
  "inactive" indicates that no rules applied on a given site.
  "disabled" indicates HTTPS Everywhere is disabled.

Disables the counter by default on Firefox (you can still turn
it on manually), and adds a new icon state "inactive."
@Hainish

Hainish commented Feb 6, 2016

Copy link
Copy Markdown
Member

This looks great! I can do a more comprehensive code review on Monday.

Comment thread chromium/manifest.json Outdated
"48": "icons/icon-active-48.png",
"128": "icons/icon-active-128.png"
},
"incognito": "split",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you went back to split incognito? (I'm guessing this was a merge issue)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, merge issue, thanks for catching!

Comment thread chromium/background.js Outdated
chrome.browserAction.setIcon({
path: newIconPath
var updateState = function() {
chrome.tabs.query({active: true}, function(tabs) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to pass currentWindow:true here, too.

Otherwise, creation order determines the tabs array, and with multiple windows, multiple tabs can be active.

Example:

  • Open a tab to a weird page (e.g. chrome://extensions)
  • The extension icon will show as inactive
  • Open a new window, and browse -- the icon state won't change

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

This has the unfortunate side effect that if you have two windows visible at once, the icon in both windows will reflect the state of whichever window is currently focused, and switching windows will change icon state (if it's different). We could probably fix this by switching back from browserAction to pageAction, but I'm not very excited about that. Probably the current behavior is fine.

@semenko

semenko commented Feb 6, 2016

Copy link
Copy Markdown
Contributor

Awesome -- Chrome bits LGTM (& tested on Stable) and they're supported in WebExtensions for an eventual FF code merger (e.g. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Tabs/query ).

I agree the current behavior is fine -- going back to pageAction would be pretty annoying.

@Hainish

Hainish commented Feb 16, 2016

Copy link
Copy Markdown
Member

When you move HTTPS Everywhere to behind the hamburger menu, the icon becomes much blurrier:

screenshot - 02162016 - 03 49 30 pm

Can we make it clearer, like in the about:addons page?

@Hainish

Hainish commented Feb 17, 2016

Copy link
Copy Markdown
Member

Within the SSL Observatory preferences, the older banner image has been replaced with a new HTTPSE image. I discussed this with @jsha, who lmk that the old HTTPSE iconography is embedded into the observatory image, looks like on the right side, in red. The original image can be found here, without this iconography: https://www.eff.org/files/sslobservatory.jpg

IMHO it seems more desirable to have a banner that's more specific to the observatory, just so people have a clearer indication of what they're looking at.

It also looks like the image width/height ratio is lessened from the original to give it a squished look, probably worth it to fix that.

@Hainish

Hainish commented Feb 17, 2016

Copy link
Copy Markdown
Member

everything else lgtm

Hainish added a commit to Hainish/https-everywhere that referenced this pull request Jun 23, 2016
@Hainish Hainish closed this Jun 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants